From 8ea3a23e270cd55f47b7bb429ca01a49a01565cd Mon Sep 17 00:00:00 2001 From: Avril Date: Sat, 21 May 2022 03:20:04 +0100 Subject: [PATCH] Using huge-pages for this is folly from the start: For one, we never actually map the fallocate()"d memory. And two... hugetlbfs does not support write()s in any way, splice()s, send_file()s... It only supports read(), and mmap() (its primary use-case...); which isn"t relevant for us. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This branch will be merged but the `hugetlb` feature flag will be removed. This matter is now closed. Fortune for collect's current commit: Future blessing − 末吉 --- Cargo.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Cargo.toml b/Cargo.toml index 8446ee7..afdc48c 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -44,11 +44,13 @@ mode-buffered = ["jemalloc", "bytes"] memfile = ["bitflags", "lazy_static", "stackalloc"] # Use `MAP_HUGE` masks when needed or asked for. +# XXX: This cannot work for our use case as we do not map the fd, we splice() to it... It's entirely useless... hugetlb = ["memfile"] # Check the conversion of kernel information into `MAP_HUGE` flags # # Usually only useful for debugging. +# XXX: See above hugepage-checked-masks = ["hugetlb"] # `memfile`: When unable to determine the size of the input, preallocate the buffer to a multiple of the system page-size before writing to it. This can save extra `ftruncate()` calls, but will also result in the buffer needing to be truncated to the correct size at the end if the sizes as not matched.