impl `Read` for `Source`: Implemented for internal and external buffer usage

TODO: Rename reuse-buffer to ad-hoc-buffer: We can"t update crypter in-place, need a seperate buffer :/

Fortune for chacha20stream's current commit: Small blessing − 小吉
read-stream-wrapper
Avril 3 years ago
parent 6cbbf2bd2c
commit 843616e35e
Signed by: flanchan
GPG Key ID: 284488987C31F630

@ -195,7 +195,7 @@ where R: Read
{ {
#[cfg(feature="explicit_clear")] #[cfg(feature="explicit_clear")]
{ {
bytes::explicit_prune(K::buffer_bytes_mut(self)); bytes::explicit_prune(K::buffer_bytes_mut(&mut self.buffer));
return; return;
} }
#[cfg(not(feature="explicit_clear"))] #[cfg(not(feature="explicit_clear"))]
@ -232,20 +232,37 @@ impl<R> Source<R, UseBufferInternal>
} }
} }
fn try_alloca<T>(sz: usize, cb: impl FnOnce(&mut [u8]) -> T) -> T
{
if sz > STACK_MAX_BYTES {
let mut bytes = vec![0u8; sz];
cb(&mut bytes[..])
} else {
stackalloc::alloca_zeroed(sz, cb)
}
}
impl<R: ?Sized, K: ?Sized + BufferKind> Read for Source<R, K> impl<R: ?Sized, K: ?Sized + BufferKind> Read for Source<R, K>
where R: Read where R: Read
{ {
fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> { fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
if cfg!(feature="reuse-buffer") { if cfg!(feature="reuse-buffer") {
//XXX: FUck, we can't `crypter.update()` in place.... //XXX: FUck, we can't `crypter.update()` in place....
let read = self.stream.read(buf)?;
todo!() try_alloca(buf.len(), move |temp| -> io::Result<usize> {
let read = self.stream.read(temp)?;
let b = self.transform_into(&temp[..read], &mut buf[..read])?;
#[cfg(feature="explicit_clear")] bytes::explicit_prune(&mut temp[..b]);
Ok(b)
})
} }
else { else {
self.grow_to_fit(buf.len()); self.grow_to_fit(buf.len());
let read = self.stream.read(&mut K::buffer_bytes_mut(&mut self.buffer)[..buf.len()])?; let read = self.stream.read(&mut K::buffer_bytes_mut(&mut self.buffer)[..buf.len()])?;
Ok(self.transform(read, &mut buf[..read])?) let b = self.transform(read, &mut buf[..read])?;
#[cfg(feature="explicit_clear")] bytes::explicit_prune(&mut K::buffer_bytes_mut(&mut self.buffer)[..b]);
Ok(b)
} }
} }
} }

Loading…
Cancel
Save